Skip to content

Fix: prevent buffer overflow by limiting amount of data copied. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Fix: prevent buffer overflow by limiting amount of data copied. #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/system.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,10 @@ void HAL_SPI_TxRxCpltCallback(SPI_HandleTypeDef *hspi)
struct complete_packet *tx_pkt = (struct complete_packet *)p_tx_buf_transfer;
struct complete_packet *rx_pkt = (struct complete_packet *)RX_Buffer;

/* Limit the amount of data copied to prevent buffer overflow. */
if (rx_pkt->header.size > sizeof(rx_pkt_userspace))
rx_pkt->header.size = sizeof(rx_pkt_userspace);

/* The SPI transfer is now complete, copy to userspace memory. */
memcpy((void *)rx_pkt_userspace, &(rx_pkt->data), rx_pkt->header.size);

Expand Down