Skip to content

Removed useless goroutine in conversation handler #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

Removed useless goroutine in conversation handler #15

merged 1 commit into from
May 23, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 23, 2022 •
edited
Loading

This makes the whole architecture much simpler.

It also makes the output synchronous, so it fixes #13.

@cmaglie cmaglie requested a review from a team May 23, 2022 10:33
@cmaglie cmaglie self-assigned this May 23, 2022
@cmaglie
Copy link
Member Author

cmaglie commented May 23, 2022

/cc @silvanocerza

@cmaglie cmaglie merged commit a56d908 into main May 23, 2022
@cmaglie cmaglie deleted the simplify branch May 23, 2022 13:15
@per1234 per1234 added the topic: code Related to content of the project itself label May 23, 2022
@silvanocerza
Copy link

@cmaglie

obi

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QUIT command response is not specification compliant
4 participants
@cmaglie @silvanocerza @umbynos @per1234