Skip to content

Update repositories.txt #5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update repositories.txt #5727

wants to merge 1 commit into from

Conversation

YoavPaz
Copy link
Contributor

@YoavPaz YoavPaz commented Jan 8, 2025

Copy link
Contributor

github-actions bot commented Jan 8, 2025

A problem was found with your submission https://github.com/YoavPaz/I2CR-CPP

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @YoavPaz
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 mentioned this pull request Jan 8, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YoavPaz. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/YoavPaz/I2CR-CPP/tree/1.0.0

(note that the library was in a subfolder of the repository at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jan 8, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoavPaz
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️ PLEASE READ THIS IMPORTANT INFORMATION ⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
@YoavPaz

❗🛑❗STOP SUBMITTING PULL REQUESTS OVER AND OVER AGAIN❗🛑❗

As the bot has clearly communicated already, there is no need or point in submitting a new pull request after a problem is detected with your existing PR.

What you must do instead is CAREFULLY read the information provided by the bot and then fix the problem. Once you do that, another round of automated checks will be triggered. You can repeat that process in a single pull request as many times as is needed to get it to a fully compliant state. Once your submission passes all the checks it will automatically be accepted by the bot.

You will never fix the problem by submitting the same non-compliant pull request multiple times. That will only waste your time and the time of the humans who maintain this free open source project.

If you have any questions, concerns, or problems, you are welcome to write a clear and detailed request in a comment here. I'll be happy to provide assistance.


⚠ If you cannot act in a respectful and responsible manner when interacting with Arduino's repositories, you will be permanently banned.


Thanks in advance for your cooperation.

@per1234 per1234 self-assigned this Jan 9, 2025
@per1234 per1234 closed this Jan 9, 2025
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: waiting for information More information must be provided before work can proceed labels Jan 9, 2025
@per1234 per1234 mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants