Skip to content

chore: update url of "MP3 Player" #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

Lesords
Copy link
Contributor

@Lesords Lesords commented Dec 25, 2024

No description provided.

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 25, 2024
Copy link
Contributor

Hi @Lesords.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/Seeed-Studio/Seeed_Serial_MP3_Player:

Linting library in Seeed_Serial_MP3_Player
INFO: No header file found matching library name (Seeed_Serial_MP3_Player.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Seeed Serial MP3 Player contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Seeed Serial MP3 Player not found in the Library Manager index. Library names are not allowed to    
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/All_Terminal_player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/KT403A_Terminal_player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/WT2003S_Terminal_Player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/WT2605C_Terminal_Player

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Lesords
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 25, 2024 08:59
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: modification Change existing list entry labels Dec 25, 2024
@github-actions github-actions bot removed the request for review from per1234 December 25, 2024 09:16
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Seeed-Studio/Seeed_Serial_MP3_Player:

Linting library in Seeed_Serial_MP3_Player
INFO: No header file found matching library name (Seeed_Serial_MP3_Player.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Seeed Serial MP3 Player contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/All_Terminal_player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/KT403A_Terminal_player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/WT2003S_Terminal_Player

Linter results for project: no errors or warnings

-------------------

Linting sketch in Seeed_Serial_MP3_Player/examples/WT2605C_Terminal_Player

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 5cf2d5b into arduino:main Dec 25, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Seeed-Studio/Seeed_Serial_MP3_Player/

github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant