Skip to content

Remove some libraries #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

Lzw655
Copy link
Contributor

@Lzw655 Lzw655 commented Sep 24, 2024

I apologize for the inconvenience. Due to the renaming and modifications of the esp-ui software, I need to perform the following actions:

  1. Rename 'esp-ui' to 'esp-brookesia' and update the URL
  2. Remove unnecessary libraries, as they are now included in the 'esp-brookesia' library

@github-actions github-actions bot added the topic: modification Change existing list entry label Sep 24, 2024
Copy link
Contributor

Hi @Lzw655.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/espressif/esp-brookesia:

Linting library in esp-brookesia
INFO: No header file found matching library name (esp-brookesia.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name esp-brookesia not found in the Library Manager index. Library names are not allowed to change after 
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in esp-brookesia/examples/arduino/ESP_Brookesia_Phone

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Lzw655
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Lzw655. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added topic: URL change Change library repository URL topic: removal Remove library from the list status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Sep 24, 2024
@Lzw655
Copy link
Contributor Author

Lzw655 commented Sep 24, 2024

@per1234 Thank you very much!

@MatteoPologruto MatteoPologruto self-assigned this Oct 2, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/10/02 16:10:50 Loaded 7334 libraries from DB
Removing esp-ui
Success!
2024/10/02 16:11:49 Loaded 7333 libraries from DB
Removing esp-ui-phone_320_240_stylesheet
Success!
2024/10/02 16:15:14 Loaded 7332 libraries from DB
Removing esp-ui-phone_480_480_stylesheet
Success!
2024/10/02 16:17:52 Loaded 7331 libraries from DB
Removing esp-ui-phone_800_480_stylesheet
Success!
2024/10/02 16:19:50 Loaded 7330 libraries from DB
Removing esp-ui-phone_1024_600_stylesheet
Success!

@MatteoPologruto MatteoPologruto merged commit 97c35d7 into arduino:main Oct 2, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants