Skip to content

Update repositories.txt #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Update repositories.txt #5112

merged 1 commit into from
Sep 16, 2024

Conversation

lucweb
Copy link
Contributor

@lucweb lucweb commented Sep 16, 2024

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 16, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/lucweb/SmartLadderFirmware:

Linting library in SmartLadderFirmware
INFO: No header file found matching library name (SmartLadder.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Sketch(es) found outside examples and extras folders:                                    
           SmartLadderFirmware/test/mocks                                                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in SmartLadderFirmware/examples/Basic/arduino

Linter results for project: no errors or warnings

-------------------

Linting sketch in SmartLadderFirmware/examples/Basic/esp32

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 95717a6 into arduino:main Sep 16, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/lucweb/SmartLadderFirmware/

github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@lucweb
Copy link
Contributor Author

lucweb commented Oct 8, 2024

@ArduinoBot, please run the checks again after the bug fix.

@per1234
Copy link
Contributor

per1234 commented Oct 9, 2024

Hello @lucweb. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

If you want to validate your library, you can directly use the Arduino Lint tool the bot used to run the checks:

https://arduino.github.io/arduino-lint/


You might consider setting up an automated check in your library repository for compliance with the Library Manager requirements. This could run on every commit and pull request to ensure such violations are caught immediately.

Arduino provides a GitHub Actions action that makes this very easy to do by adding a simple YAML file to the repository:

https://github.com/arduino/arduino-lint-action#readme

It is in use in all the official Arduino library repositories (example).


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants