Skip to content

Add 9704 Launch Pad library to repositories.txt #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

IRDMPE
Copy link
Contributor

@IRDMPE IRDMPE commented Sep 10, 2024

Adds 3rd party Arduino library to support the 9704 Launch Pad

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 10, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://gitlab.com/iridium/9704_launch_pad/arduino_library:

Linting library in arduino_library
INFO: No header file found matching library name (Iridium_9704_Launch_Pad.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Iridium 9704 Launch Pad is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Iridium 9704 Launch Pad contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in arduino_library/examples/Connectivity

Linter results for project: no errors or warnings

-------------------

Linting sketch in arduino_library/examples/Dashboard

Linter results for project: no errors or warnings

-------------------

Linting sketch in arduino_library/examples/ExternalControlMode

Linter results for project: no errors or warnings

-------------------

Linting sketch in arduino_library/examples/FirmwareUpdate

Linter results for project: no errors or warnings

-------------------

Linting sketch in arduino_library/examples/Reflector

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 41ea4de into arduino:main Sep 10, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/gitlab.com/iridium/9704_launch_pad/arduino_library/

github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@IRDMPE
Copy link
Contributor Author

IRDMPE commented Sep 11, 2024

@ArduinoBot check again?

@per1234
Copy link
Contributor

per1234 commented Sep 11, 2024

Hello @IRDMPE. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

If you like the checks that were performed by the automated system when you submitted your library here, you might consider setting up your library repository to do the same. This could run on every commit and pull request to ensure such violations are caught immediately.

Arduino provides a GitHub Actions action that makes this very easy to do by adding a simple YAML file to the repository:

https://github.com/arduino/arduino-lint-action#readme

This action uses the same Arduino Lint tool as the Library Manager system.

It is in use in all the official Arduino library repositories (example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants