Skip to content

Update repositories.txt #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Update repositories.txt #5067

merged 2 commits into from
Sep 12, 2024

Conversation

AndreiOp235
Copy link
Contributor

Change library name/URL to remove warning

Change library name/URL to remove warning
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Hi @AndreiOp235.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

ERROR: Arduino Lint found errors with https://github.com/AndreiOp235/24s02ya__M24SR02-Y:

Linting library in 24s02ya__M24SR02-Y
INFO: No header file found matching library name (24s02ya__M24SR02-Y_Library.h). Best practices are for primary header  
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value 24s02ya__M24SR02-Y_Library is longer than the recommended length of 16           
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: Library name 24s02ya__M24SR02-Y_Library contains "library". This is superfluous.                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
ERROR: Library name 24s02ya__M24SR02-Y_Library not found in the Library Manager index. Library names are not allowed to 
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties depends field item(s) Wire not found in the Library Manager index.                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           24s02ya__M24SR02-Y                                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 1 ERRORS, 4 WARNINGS

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/LibraryCapabilities

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadCCfile

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadNDEF

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadSystem

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 4 WARNINGS

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @AndreiOp235
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 September 5, 2024 15:07
@AndreiOp235 AndreiOp235 closed this Sep 5, 2024
@AndreiOp235 AndreiOp235 deleted the patch-1 branch September 5, 2024 15:12
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiOp235 we're happy to take care of this for you. But we can only do that if you leave the pull request open!!!!

So what do you want to do???

@AndreiOp235 AndreiOp235 restored the patch-1 branch September 5, 2024 15:21
@AndreiOp235
Copy link
Contributor Author

AndreiOp235 commented Sep 5, 2024

@per1234
i just wanted to change the URL name(due to a warning in the lint action) but then the bot reported an error

Can you remove my URL from the repositories.txt (https://github.com/AndreiOp235/24s02ya__M24SR02-Y_Library) to make sure that everything is compliant ?

I will contribute back when the library is ok

@AndreiOp235 AndreiOp235 reopened this Sep 5, 2024
@per1234
Copy link
Contributor

per1234 commented Sep 5, 2024

Can you remove my URL from the repositories.txt (https://github.com/AndreiOp235/24s02ya__M24SR02-Y_Library) to make sure that everything is compliant ?

Absolutely not. If you want to request a name change then you must follow the standard procedure, as described in the documentation:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name

Just the same, if you want to request the URL be updated, then you follow the standard procedure for that, as you already did here before you freaked out and closed the pull request.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndreiOp235. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Sep 5, 2024
@AndreiOp235
Copy link
Contributor Author

Thanks @per1234 for the patience of trying to understand me !

I managed to fix most of the lint warnings on my part. I`ll wait for the closing notification from Github

@MatteoPologruto MatteoPologruto self-assigned this Sep 12, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/09/12 16:08:35 Loaded 7292 libraries from DB
Removing 24s02ya__M24SR02-Y_Library
Success!

Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Sep 12, 2024
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/AndreiOp235/24s02ya__M24SR02-Y:

Linting library in 24s02ya__M24SR02-Y
WARNING: library.properties name value 24s02ya__M24SR02-Y is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            
ERROR: Library name 24s02ya__M24SR02-Y not found in the Library Manager index. Library names are not allowed to change  
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/LibraryCapabilities

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadCCfile

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadNDEF

Linter results for project: no errors or warnings

-------------------

Linting sketch in 24s02ya__M24SR02-Y/examples/ReadSystem

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @MatteoPologruto
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 September 12, 2024 16:13
@MatteoPologruto MatteoPologruto merged commit 9bac37a into arduino:main Sep 12, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants