Skip to content

Update repositories.txt #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Update repositories.txt #4904

merged 1 commit into from
Aug 1, 2024

Conversation

giocip
Copy link
Contributor

@giocip giocip commented Jul 31, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 31, 2024
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/giocip/ARDUINO_num7:

Linting library in ARDUINO_num7
ERROR: library.properties version value v1.0.0 is invalid.                                                   
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP020)                                                                                          
WARNING: library.properties version value v1.0.0 is not compliant with the semver specification.
         See: https://semver.org/                                                               
         (Rule LP021)                                                                           

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ARDUINO_num7/examples/calculator

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @giocip
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@giocip
Copy link
Contributor Author

giocip commented Jul 31, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/giocip/ARDUINO_num7:

Linting library in ARDUINO_num7
ERROR: library.properties version value v1.0.0 is invalid.                                                   
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP020)                                                                                          
WARNING: library.properties version value v1.0.0 is not compliant with the semver specification.
         See: https://semver.org/                                                               
         (Rule LP021)                                                                           

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ARDUINO_num7/examples/calculator

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@giocip
Copy link
Contributor Author

giocip commented Jul 31, 2024

@ArduinoBot

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @giocip
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/giocip/ARDUINO_num7:

Linting library in ARDUINO_num7
ERROR: library.properties version value v1.0.0 is invalid.                                                   
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP020)                                                                                          
WARNING: library.properties version value v1.0.0 is not compliant with the semver specification.
         See: https://semver.org/                                                               
         (Rule LP021)                                                                           

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ARDUINO_num7/examples/calculator

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @giocip
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @giocip. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/giocip/ARDUINO_num7/blob/1.0.0/library.properties#L2

version=v1.0.0

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 31, 2024
@giocip
Copy link
Contributor Author

giocip commented Aug 1, 2024

@ArduinoBot

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Aug 1, 2024
@github-actions github-actions bot merged commit a7cb1aa into arduino:main Aug 1, 2024
12 checks passed
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/giocip/ARDUINO_num7/

github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
egnor pushed a commit to egnor/library-registry that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants