Skip to content

Update URL for jhagas/ESPSupabase #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

Update URL for jhagas/ESPSupabase #4804

merged 2 commits into from
Jul 29, 2024

Conversation

jhagas
Copy link
Contributor

@jhagas jhagas commented Jul 19, 2024

Initially, this library is designed for ESP32. By the work of contributors, we make this library works for ESP8266, so i change the name of library and the GitHub link, so people will not confuse about this library support.

@jhagas
Update repositories.txt
2ee4b3c 
Initially, this library is designed for ESP32, but contributor make it works also for ESP8266, so i change the name of library and the GitHub link, so people will not confuse about this library support.
@github-actions github-actions bot added the topic: modification Change existing list entry label Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi @jhagas.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/jhagas/ESPSupabase:

Linting library in ESPSupabase
ERROR: Library name ESPSupabase not found in the Library Manager index. Library names are not allowed to change after   
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in ESPSupabase/examples/insert

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/login-email

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/login-phone

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/realtime-postgresChanges

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/select

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/update

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/upload

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @jhagas
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 July 19, 2024 05:09
@jhagas jhagas changed the title Update repositories.txt Change link of jhagas/ESPSupabase Jul 19, 2024
@jhagas jhagas changed the title Change link of jhagas/ESPSupabase Update URL for jhagas/ESPSupabase Jul 19, 2024
@per1234 per1234 added topic: URL change Change library repository URL topic: rename Change registered library name and removed topic: modification Change existing list entry labels Jul 19, 2024
@per1234 per1234 mentioned this pull request Jul 19, 2024
Merged
per1234
per1234 reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jhagas. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added status: pending backend Depends on backend maintenance operations and removed topic: rename Change registered library name labels Jul 19, 2024
@per1234
Copy link
Contributor

per1234 commented Jul 19, 2024 

ERROR: Library name ESPSupabase not found in the Library Manager index. Library names are not allowed to change after   
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)

This error from the linter is expected and will be resolved by the registered name update provided by

@umbynos umbynos self-assigned this Jul 29, 2024
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi @umbynos.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/jhagas/ESPSupabase:

Linting library in ESPSupabase
ERROR: Library name ESPSupabase not found in the Library Manager index. Library names are not allowed to change after   
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in ESPSupabase/examples/insert

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/login-email

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/login-phone

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/realtime-postgresChanges

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/select

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/update

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPSupabase/examples/upload

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

umbynos
umbynos approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #4805 (review)

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @umbynos
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 July 29, 2024 13:11
@umbynos umbynos added the status: pending backend Depends on backend maintenance operations label Jul 29, 2024
@umbynos umbynos merged commit 49d9ba0 into arduino:main Jul 29, 2024
12 checks passed
@umbynos umbynos added the conclusion: resolved Issue was resolved label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@umbynos umbynos

Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: modification Change existing list entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhagas @per1234 @umbynos