Skip to content

Remove ArdUAV, navduino, and other libs #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove ArdUAV, navduino, and other libs #4800

wants to merge 2 commits into from

Conversation

PowerBroker2
Copy link
Contributor

Please remove the following libraries:

  • ArdUAV
  • Autopilot
  • navduino
  • NEO-6M_GPS
  • UM7

Copy link
Contributor

Hi @PowerBroker2.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: removal Remove library from the list label Jul 17, 2024
@github-actions github-actions bot requested a review from per1234 July 17, 2024 17:25
@PowerBroker2
Copy link
Contributor Author

@per1234

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PowerBroker2. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jul 28, 2024
Copy link
Contributor

Hi @PowerBroker2.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the status: pending backend Depends on backend maintenance operations label Jul 29, 2024
@github-actions github-actions bot requested a review from per1234 July 29, 2024 04:53
@PowerBroker2 PowerBroker2 closed this by deleting the head repository Jul 29, 2024
@per1234 per1234 self-assigned this Jul 29, 2024
@per1234
Copy link
Contributor

per1234 commented Jul 29, 2024

@PowerBroker2 I see you deleted your fork of this repository. That caused the pull request to be closed.

Did you decide you no longer wish to have these libraries removed?

If you still want to have them removed, it is important that this pull request be merged instead of being closed.

@umbynos umbynos added the status: waiting for information More information must be provided before work can proceed label Jul 29, 2024
@PowerBroker2
Copy link
Contributor Author

I had some new libraries I wanted to add to the list, but didn't know how to update my fork properly. I took a risk to just delete my fork, refork, and start from scratch, but I didn't realize it would delete all the PRs for library removal.

I still want the libs removed, though. I just had a screw up trying to add other libs.

@per1234
Copy link
Contributor

per1234 commented Jul 29, 2024

In the future, create a dedicated branch in your fork for each pull request. Push any changes you want to submit via the PR to that branch. This way you can manage multiple PRs for independent changes without interference with each other.

You should never submit a pull request from the main branch of a fork. This way you can simply click the convenient "Sync fork" button on your fork's GitHub web interface to bring the fork's main branch up to date with the parent repository's main before creating each new PR branch off the main branch.

If you created a fork solely for the purposes of submitting PRs and all the PRs have been merged, you can then delete the fork, but you should not delete it while PRs submitted from the fork are still open.

I still want the libs removed, though.

OK, I recreated the PR on your behalf: #4878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for information More information must be provided before work can proceed topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants