Skip to content

Remove icm45688p support #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Remove icm45688p support #4768

merged 1 commit into from
Jul 18, 2024

Conversation

gjabouley-invn
Copy link
Contributor

Hello

this PR removes the support for TDK icm45688p sensor, for legal reason.

How is managed the internal copy done by Arduino in https://downloads.arduino.cc/libraries ? Is it deleted automatically, or do we need to create specific request?

{
   "name": "ICM45688P",
   "version": "1.0.0",
   "author": "TDK/Invensense",
   "maintainer": "TDK/Invensense",
   "sentence": "Allows to read accelerometer, gyroscope and temperature sensors from an ICM45688P Invensence IMU device.",
   "paragraph": "This library allows to easily configure and log accelerometer, gyroscope and temperature data from an ICM45688P device, using the SPI or the I2C interface. It also provides embedded algorithms such as Tap, Tilt, Step counter, Wake on Motion...",
   "website": "https://github.com/tdk-invn-oss/motion.arduino.ICM45688P",
   "category": "Sensors",
   "architectures": [
       "*"
   ],
   "types": [
       "Contributed"
   ],
   "repository": "https://github.com/tdk-invn-oss/motion.arduino.ICM45688P.git",
   "providesIncludes": [
       "ICM456xx.h"
   ],
   "url": "https://downloads.arduino.cc/libraries/github.com/tdk-invn-oss/ICM45688P-1.0.0.zip",
   "archiveFileName": "ICM45688P-1.0.0.zip",
   "size": 2078772,
   "checksum": "SHA-256:b66f8a3f71f46822df87fa1d33cfe7d294c34968543e578b25533472c0adca35"
},

Copy link
Contributor

Hi @gjabouley-invn.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: removal Remove library from the list label Jul 11, 2024
@github-actions github-actions bot requested a review from per1234 July 11, 2024 08:15
@per1234 per1234 mentioned this pull request Jul 12, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello . I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

How is managed the internal copy done by Arduino in https://downloads.arduino.cc/libraries ? Is it deleted automatically, or do we need to create specific request?

It will be removed by the index maintainer when they handle this request. You don't need to take any additional action.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jul 12, 2024
@MatteoPologruto MatteoPologruto self-assigned this Jul 18, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/07/18 14:57:51 Loaded 7153 libraries from DB
Removing ICM45688P
warning: Library Git clone folder /home/ubuntu/workspace/gitclones/github.com/tdk-invn-oss/motion.arduino.ICM45688P not present
Success!

@MatteoPologruto MatteoPologruto merged commit 4674fb5 into arduino:main Jul 18, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Jul 18, 2024
@gjabouley-invn
Copy link
Contributor Author

Thanks a lot
Will the link https://downloads.arduino.cc/libraries/github.com/tdk-invn-oss/ICM45688P-1.0.0.zip be invalidated at some point?
Archive can still be manually downloaded for now

@gjabouley-invn
Copy link
Contributor Author

@MatteoPologruto sorry to ping you directly, can you please confirm above point? Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants