Skip to content

Change library name #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

Change library name #4750

merged 1 commit into from
Jul 18, 2024

Conversation

krosDC
Copy link
Contributor

@krosDC krosDC commented Jul 4, 2024

We need to change the library name because a rebranding of the product associated to the library.

@krosDC
Change library name
576e234 
We need to change the library name because a rebranding of the product associated to the library.
@github-actions github-actions bot added the topic: modification Change existing list entry label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Hi @krosDC.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

❌ ERROR: Arduino Lint found errors with https://github.com/DigitalCodesign/MentorBit-Library:

Linting library in MentorBit-Library
INFO: No header file found matching library name (MentorBit-Library.h). Best practices are for primary header filename  
      to match library name.                                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value MentorBit-Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
WARNING: Library name MentorBit-Library contains "library". This is superfluous.                               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
ERROR: Library name MentorBit-Library not found in the Library Manager index. Library names are not allowed to change   
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: Sketch(es) found outside examples and extras folders:                                    
           MentorBit-Library/exercises/meteoLogic                                                 
           MentorBit-Library/exercises/secuentialPorts                                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/LedDeColores

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/LedRgb

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/Potenciometro

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/PulsadoresAnalogicos

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/PulsadoresDigitales

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/B�sicos/Zumbador

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/DataLogger/RTC

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/DataLogger/TarjetaSD

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Display/Display7Segments

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Motores/MotorDC

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Motores/MotorPasoAPaso

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Motores/Servomotor

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Pantallas/LCD

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Pantallas/OLED

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/PuertosGenericos/Puerto_1

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/PuertosGenericos/Puerto_2

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/PuertosGenericos/Puerto_3

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Sensores/DHT

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Sensores/DS18B20

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Sensores/LDR

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Sensores/MQ

Linter results for project: no errors or warnings

-------------------

Linting sketch in MentorBit-Library/examples/Sensores/Ultrasonidos

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @krosDC
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 July 4, 2024 09:02
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Jul 4, 2024
@per1234 per1234 mentioned this pull request Jul 4, 2024
Merged
per1234
per1234 reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krosDC. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jul 4, 2024
@per1234
Copy link
Contributor

per1234 commented Jul 4, 2024 

ERROR: Library name MentorBit-Library not found in the Library Manager index. Library names are not allowed to change   
       after being added to the index.

This error from the linter is expected and will be resolved by the registered name update provided by #4753

@MatteoPologruto MatteoPologruto self-assigned this Jul 18, 2024
MatteoPologruto
MatteoPologruto approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/07/18 14:52:14 Loaded 7156 libraries from DB
Removing DC-Core-Library
Success!

@MatteoPologruto MatteoPologruto merged commit 9a52192 into arduino:main Jul 18, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krosDC @per1234 @MatteoPologruto