Skip to content

Update URL of "EiMOS_U8X8" #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 9, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jun 9, 2024

Hi @per1234.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

ERROR: Arduino Lint found errors with https://github.com/ChitoKim/EiMOS_U8X8:

Linting library in EiMOS_U8X8
ERROR: Library name EiMOS_U8X8 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: Missing architectures field in library.properties                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP043)                                                                                          

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in EiMOS_U8X8/examples/ESP32_AMOS_MONSTER

Linter results for project: no errors or warnings

-------------------

Linting sketch in EiMOS_U8X8/examples/MEGA2560_CENTURY_GOLD

Linter results for project: no errors or warnings

-------------------

Linting sketch in EiMOS_U8X8/examples/PICO_AMOS_MONSTER

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

github-actions bot commented Jun 9, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @per1234
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor Author

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error reported by the bot:

ERROR: Library name EiMOS_U8X8 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                                                                                                                         

Is expected since the library name was changed at the same time as the URL change. The error will be resolved by #4649.

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Jun 9, 2024
@MatteoPologruto MatteoPologruto self-assigned this Jun 13, 2024
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Jun 13, 2024
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/ChitoKim/EiMOS_U8X8:

Linting library in EiMOS_U8X8
ERROR: Library name EiMOS_U8X8 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: Missing architectures field in library.properties                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP043)                                                                                          

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in EiMOS_U8X8/examples/ESP32_AMOS_MONSTER

Linter results for project: no errors or warnings

-------------------

Linting sketch in EiMOS_U8X8/examples/MEGA2560_CENTURY_GOLD

Linter results for project: no errors or warnings

-------------------

Linting sketch in EiMOS_U8X8/examples/PICO_AMOS_MONSTER

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @MatteoPologruto
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/06/13 15:08:27 Loaded 7063 libraries from DB
Removing mahjongAsst_U8X8
Success!

@MatteoPologruto MatteoPologruto merged commit 9e15dc3 into arduino:main Jun 13, 2024
11 of 12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Jun 13, 2024
@per1234 per1234 deleted the move-EiMOS_U8X8 branch July 4, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants