Skip to content

fix LiquidCrystal_I2C url #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

fix LiquidCrystal_I2C url #4479

merged 1 commit into from
May 13, 2024

Conversation

cbcGirard
Copy link
Contributor

Original repo URL (https://github.com/marcoschwartz/LiquidCrystal_I2C) now redirects to https://github.com/johnrickman/LiquidCrystal_I2C, preventing installation through library manager. Updated to redirected URL.

change URL to where the original repo now redirects
@github-actions github-actions bot added the topic: modification Change existing list entry label Apr 30, 2024
Copy link
Contributor

Hi @cbcGirard.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/johnrickman/LiquidCrystal_I2C:

Linting library in LiquidCrystal_I2C
WARNING: library.properties name value LiquidCrystal_I2C is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
ERROR: Library name LiquidCrystal_I2C not found in the Library Manager index. Library names are not allowed to change   
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in LiquidCrystal_I2C/examples/CustomChars
WARNING: CustomChars.pde uses deprecated .pde file extension. Use .ino for Arduino sketches.          
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files
         (Rule SS004)                                                                                 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LiquidCrystal_I2C/examples/HelloWorld
WARNING: HelloWorld.pde uses deprecated .pde file extension. Use .ino for Arduino sketches.           
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files
         (Rule SS004)                                                                                 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LiquidCrystal_I2C/examples/SerialDisplay
WARNING: SerialDisplay.pde uses deprecated .pde file extension. Use .ino for Arduino sketches.        
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files
         (Rule SS004)                                                                                 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @cbcGirard
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cbcGirard. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Apr 30, 2024
@MatteoPologruto MatteoPologruto self-assigned this May 13, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/05/13 14:15:21 Loaded 6904 libraries from DB
Changing URL of library LiquidCrystal I2C from https://github.com/marcoschwartz/LiquidCrystal_I2C.git to https://github.com/johnrickman/LiquidCrystal_I2C.git
Success!

@MatteoPologruto MatteoPologruto merged commit 6671d74 into arduino:main May 13, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants