Skip to content

Revert "Update repositories.txt" #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

adrian2793
Copy link
Contributor

Reverts #4409

@github-actions github-actions bot added the topic: removal Remove library from the list label Apr 23, 2024
Copy link
Contributor

Hi @adrian2793.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 April 23, 2024 06:01
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @adrian2793. I see you have proposed the removal of the library immediately after adding it. Since this is quite an unusual thing to do, I have a suspicion that your true goal is to accomplish something other than a permanent removal and you are attempting to accomplish that goal via a circuitous and hacky procedure of your own devising.

So please add a comment here on the pull request thread that provides a detailed description of the reason for this pull request.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Apr 23, 2024
@adrian2793
Copy link
Contributor Author

@per1234 I want to delete it since I changed the name of the repository and I didn't wanted to make a name change request

@per1234 per1234 added topic: URL change Change library repository URL and removed status: waiting for information More information must be provided before work can proceed topic: removal Remove library from the list labels Apr 23, 2024
@per1234
Copy link
Contributor

per1234 commented Apr 23, 2024

Ugh. I see now that you submitted it again at #4411

I also see that this is the second time you have requested a removal of this library: #4245

Although the submission system is automated, the other requests are time consuming. You are making a lot of work for us. For the benefit of the community, Arduino has opened the Library Manager distribution service to everyone instead of restricting it to only official libraries. If every one of the thousands of library maintainers started removing and re-adding libraries unnecessarily we would have to stop offering this service to the community so the way you are behaving is irresponsible.

Since it was added twice, we will proceed with removing the URL as you requested here, but in the future, please only request library removals if it is absolutely essential to do so, such as if a library becomes completely obsolete. Removals must only be requested if you plan to permanently remove the library. This behavior of removing and then re-adding libraries is not allowed.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Apr 23, 2024
@MatteoPologruto MatteoPologruto self-assigned this Apr 29, 2024
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: removal Remove library from the list and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Apr 29, 2024
@github-actions github-actions bot requested a review from per1234 April 29, 2024 16:05
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/04/29 16:00:58 Loaded 6877 libraries from DB
Changing URL of library AISwitch from https://github.com/arduino279/ArduinoAI.git to https://github.com/arduino279/AI.git
Success!

@MatteoPologruto MatteoPologruto merged commit 607b041 into arduino:main Apr 29, 2024
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Apr 29, 2024
Copy link
Contributor Author

@adrian2793 adrian2793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, good work, mate! This is a review for you : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants