Skip to content

Update repositories.txt #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Update repositories.txt #4228

merged 1 commit into from
Mar 17, 2024

Conversation

locple
Copy link
Contributor

@locple locple commented Mar 17, 2024

Add LiquidCrystal_I2C_UTF8 to the library manager

Copy link
Contributor

A problem was found with your submission https://github.com/locple/LiquidCrystal_I2C_UTF8

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 17, 2024
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @locple
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@locple
Copy link
Contributor Author

locple commented Mar 17, 2024

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

@locple
Copy link
Contributor Author

locple commented Mar 17, 2024

@ArduinoBot

@github-actions github-actions bot requested a review from per1234 March 17, 2024 18:19
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 March 17, 2024 18:19
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/locple/LiquidCrystal_I2C_UTF8:

Linting library in LiquidCrystal_I2C_UTF8
INFO: No header file found matching library name (LiquidCrystal_I2C_UTF8.h). Best practices are for primary header      
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value LiquidCrystal I2C UTF8 is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format      
         (Rule LP010)                                                                                                
WARNING: library.properties name LiquidCrystal I2C UTF8 contains spaces. Although supported, best practices is to not   
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: library.properties depends field item(s) LiquidCrystal_I2C not found in the Library Manager index.    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/Demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/DemoVietRus

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/DemoVietnamese

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/LongStringEnglish

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/LongStringRussian

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/LongStringVietnamese

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/StringsRussian

Linter results for project: no errors or warnings

-------------------

Linting sketch in LiquidCrystal_I2C_UTF8/examples/StringsVietnamese

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit e1d3c36 into arduino:main Mar 17, 2024
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/locple/LiquidCrystal_I2C_UTF8/

github-actions bot pushed a commit that referenced this pull request Mar 17, 2024
@locple
Copy link
Contributor Author

locple commented Mar 17, 2024

@ArduinoBot

@per1234
Copy link
Contributor

per1234 commented Mar 17, 2024

Hello @locple. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

But this human is happy to provide assistance. Was there something you needed from the bot?

@locple
Copy link
Contributor Author

locple commented Mar 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants