Skip to content

Update Repository Name Supabase-ESP32 to Supabase-Arduino #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

zumatt
Copy link
Contributor

@zumatt zumatt commented Mar 7, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi @zumatt.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/zumatt/Supabase-Arduino:

Linting library in Supabase-Arduino
INFO: No header file found matching library name (Supabase-ESP32.h). Best practices are for primary header filename to  
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Missing architectures field in library.properties                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP043)                                                                                          
WARNING: library.properties includes field item(s) WiFi.h, HTTPClient.h not found in library.                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in Supabase-Arduino/examples/SupabaseESP32_Demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot requested a review from per1234 March 7, 2024 16:52
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zumatt. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Mar 7, 2024
@zumatt
Copy link
Contributor Author

zumatt commented Mar 7, 2024

Hello @per1234 thank you!

No problem for that I can imagine that this is not easy.

@MatteoPologruto MatteoPologruto self-assigned this Mar 14, 2024
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Mar 14, 2024
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/zumatt/Supabase-Arduino:

Linting library in Supabase-Arduino
INFO: No header file found matching library name (Connect_Arduino-Supabase.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Connect Arduino-Supabase is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP010)                                                                                                  
WARNING: Library name Connect Arduino-Supabase contains "Arduino". This is superfluous.                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
WARNING: library.properties name Connect Arduino-Supabase contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Connect Arduino-Supabase not found in the Library Manager index. Library names are not allowed to   
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in Supabase-Arduino/examples/ESP32/Read-Update_Demo

Linter results for project: no errors or warnings

-------------------

Linting sketch in Supabase-Arduino/examples/RP2040/Read_Demo

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @MatteoPologruto
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 March 14, 2024 16:14
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/03/14 16:11:05 Loaded 6744 libraries from DB
Changing URL of library Supabase-ESP32 from https://github.com/zumatt/Supabase-ESP32.git to https://github.com/zumatt/Supabase-Arduino.git
Success!

@MatteoPologruto MatteoPologruto merged commit af344e7 into arduino:main Mar 14, 2024
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Mar 14, 2024
@zumatt
Copy link
Contributor Author

zumatt commented Mar 18, 2024

Dear @MatteoPologruto & @per1234

thank you for merging my Library.
Anyway, there's a problem with the library name.

If I check the link https://downloads.arduino.cc/libraries/logs/github.com/zumatt/Supabase-Arduino/
the last logs say:

2024/03/18 15:34:11 Checking out tag: 1.0.3
2024/03/18 15:34:11 Release Connect Arduino-Supabase:1.0.2 has wrong library name, should be Supabase-ESP32

You know how can I fix this?
I checked all the files inside the library and there's no more a connection to the old name.

Thank you,
Matteo.

@per1234
Copy link
Contributor

per1234 commented Mar 18, 2024

Hello @zumatt. We only updated the repository URL in the registry. The library is locked to the name that is defined in the registry, which is Supabase-ESP32. If you would like to change the registered name, please submit a name change request by following the procedure documented here:

https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name

Please let me know if you have any questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants