Skip to content

remove old library #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2024
Merged

remove old library #4147

merged 6 commits into from
Mar 7, 2024

Conversation

cotestatnt
Copy link
Contributor

Removal of library YA_FSM which has been replaced by the more efficient and flexible AgileStateMachine

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Hi @cotestatnt.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Mar 1, 2024
@github-actions github-actions bot requested a review from per1234 March 1, 2024 13:27
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Hi @cotestatnt.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: removal Remove library from the list and removed topic: modification Change existing list entry labels Mar 1, 2024
@per1234 per1234 mentioned this pull request Mar 1, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cotestatnt. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Mar 1, 2024
@github-actions github-actions bot removed the status: pending backend Depends on backend maintenance operations label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Hi @cotestatnt.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 March 6, 2024 09:38
@cotestatnt cotestatnt closed this Mar 6, 2024
@per1234 per1234 reopened this Mar 6, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cotestatnt. I see you closed this pull request. Did you decide you no longer wish to remove the library from Library Manager?

If you want the library to be removed from Library Manager, it is essential for this pull request to be left open. The Library Manager index maintainer will merge the pull request once they have completed the database operations that are necessary for the removal.

@per1234 per1234 added status: on hold Do not proceed at this time status: waiting for information More information must be provided before work can proceed labels Mar 6, 2024
@per1234 per1234 self-assigned this Mar 6, 2024
@cotestatnt
Copy link
Contributor Author

I apologize, I closed by mistake convinced to act elsewhere.

Yes, please remove the library.

@per1234 per1234 removed their assignment Mar 6, 2024
@per1234 per1234 added status: pending backend Depends on backend maintenance operations and removed status: on hold Do not proceed at this time status: waiting for information More information must be provided before work can proceed labels Mar 6, 2024
@MatteoPologruto MatteoPologruto self-assigned this Mar 7, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/03/07 16:47:43 Loaded 6727 libraries from DB
Removing YA_FSM
Success!

@MatteoPologruto MatteoPologruto merged commit 199b083 into arduino:main Mar 7, 2024
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants