-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Blues Notecard Environment Variable Manager #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ ERROR: Arduino Lint found errors with https://github.com/blues/notecard-env-var-manager:
|
Thanks for your interest in contributing to the Arduino Library Manager index @zfields After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zfields. Thanks for your interest in contributing to the Arduino Library Manager index.
I see the bot reported a problem with your submission that will block its acceptance:
ERROR: Symlink(s) found. Symlinks cause difficulties for Windows users. These block addition to the Arduino Library
Manager index:
notecard-env-var-manager/examples/zephyr/NotecardEnvVarManager.c
notecard-env-var-manager/examples/zephyr/NotecardEnvVarManager.h
If you have any questions or problems while following the instructions to resolve the problem, please let me know and I'll help out.
If you decide you no longer wish to submit the library, you can close this pull request.
Hi @per1234, thanks for your help in ciphering the message! The folder in question is for an unrelated Is it possible to indicate in the |
At this time, the entire contents of the repository are included in the archive generated by the Library Manager system for installation on the user's machine. There is a request for a feature that would allow something like this here: arduino/libraries-repository-engine#59
You will need to ensure the tagged releases do not contain any symlinks. One option would be to move the Zephyr example to a dedicated repository and then incorporate the library files into the example project by adding the library repository to the Zephyr example repository as a Git submodule (as I see is already being done for some other libraries). |
So if we were to create a What would be required to resubmit the CI jobs (checks)? |
Sorry, no. You are not allowed to have symlinks anywhere in your repository. You must remove them from the library repository entirely.
Just add a comment here mentioning @ArduinoBot to trigger it to run the automated checks again. Once those are passing, your library will automatically be added to Library Manager. If you have any questions or concerns, please let me know. Regards, Per |
Hello @ArduinoBot! We are ready to try again! |
Hello! I'm checking your submission again. |
❌ ERROR: Arduino Lint found errors with https://github.com/blues/notecard-env-var-manager:
|
Thanks for your interest in contributing to the Arduino Library Manager index @zfields After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zfields. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/blues/notecard-env-var-manager/tree/v1.0.0/examples/zephyr
❗ Remember to update the version
field in the library's library.properties
file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
Okay @ArduinoBot, I have a new VERSION for you to test! 👍 |
Hello! I'm checking your submission again. |
Arduino Lint has suggestions for possible improvements to https://github.com/blues/notecard-env-var-manager:
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
No description provided.