Skip to content

Removing a new library I added earlier today. #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2023
Merged

Removing a new library I added earlier today. #2901

merged 2 commits into from
May 30, 2023

Conversation

zapta
Copy link
Contributor

@zapta zapta commented May 28, 2023

After using the package in the Arduino IDE I realized that it has portability issues, e.g. because it uses vprintf. Removing it for now.

@github-actions
Copy link
Contributor

Hi @zapta.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: other Something other than a library list request label May 28, 2023
@github-actions github-actions bot requested a review from per1234 May 28, 2023 04:07
@zapta @per1234
Removed a new library I added eariler today. After using it in the
3088f8c 
Arduino IDE I realized that it's not ready for release due to
compability issues such as using vprintf.
@arduino arduino deleted a comment from github-actions bot May 29, 2023
@github-actions github-actions bot added topic: removal Remove library from the list and removed topic: other Something other than a library list request labels May 29, 2023
@per1234 per1234 mentioned this pull request May 29, 2023
Merged
per1234
per1234 reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zapta. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label May 29, 2023
@arduino arduino deleted a comment from github-actions bot May 29, 2023
@MatteoPologruto MatteoPologruto self-assigned this May 30, 2023
@github-actions github-actions bot removed the status: pending backend Depends on backend maintenance operations label May 30, 2023
@github-actions
Copy link
Contributor

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 May 30, 2023 12:42
MatteoPologruto
MatteoPologruto approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/05/30 12:40:16 Loaded 5874 libraries from DB
Removing Serial_Packets
Success!

@MatteoPologruto MatteoPologruto merged commit 713cc49 into arduino:main May 30, 2023
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved topic: removal Remove library from the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zapta @per1234 @MatteoPologruto