Skip to content

add https://github.com/flash62au/WiThrottleProtocol #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2023
Merged

add https://github.com/flash62au/WiThrottleProtocol #2900

merged 5 commits into from
May 28, 2023

Conversation

flash62au
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label May 27, 2023
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/flash62au/WiThrottleProtocol:

Linting library in WiThrottleProtocol
ERROR: Library name WiThrottle is in use by a library in the Library Manager index. Each library must have a unique name
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in WiThrottleProtocol/examples/DigitalFastClock

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottle_Basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottle_Delegate

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottle_FastTime

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottle_Roster

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @flash62au
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flash62au. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/flash62au/WiThrottleProtocol/blob/1.0.1/library.properties#L1

name=WiThrottle

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this May 28, 2023
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label May 28, 2023
@flash62au
Copy link
Contributor Author

@per1234 Much appreciated.
I think I have created the release.

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label May 28, 2023
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/flash62au/WiThrottleProtocol:

Linting library in WiThrottleProtocol
WARNING: library.properties name value WiThrottleProtocol is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in WiThrottleProtocol/examples/DigitalFastClock

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottleProtocol_Basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottleProtocol_Delegate

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottleProtocol_FastTime

Linter results for project: no errors or warnings

-------------------

Linting sketch in WiThrottleProtocol/examples/WiThrottleProtocol_Roster

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 5f9294e into arduino:main May 28, 2023
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/flash62au/WiThrottleProtocol/

github-actions bot pushed a commit that referenced this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants