Check db during integration test #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion test The checksums are different every time the index is generated, so they must be removed before comparing the index against the golden master. Previously, the approach was to delete the entire checksum key from the index data. I think a better approach is to replace the data with a placeholder because the golden master having a templated value rather than a missing key is more intuitive for maintainers.
per1234
added
type: enhancement
cmaglie
reviewed
Jun 8, 2021
cmaglie
reviewed
Jun 8, 2021
Small variation in the archive size could result from compression algorithm changes. With the previous exact comparison against the size data in the golden master index, this would cause a spurious test failure. The solution is to allow some tolerance in the sizes during the comparison. This still provides a useful "smoke test" while avoiding the test requiring undue maintenance effort.
db.json provides storage of the library index data in the Library Manager back end. The library_index.json content for previously indexed library releases is generated from this data with only the data for new releases being generated from the library repository content. For this reason, it's very important for the db.json content to be correct. Checking the db.json generated from a run of the system against a "golden master" provides improved confidence that the content remains correct during development on the project. The "golden master" db.json was checked against the one generated by the final "production" engine version (60ebae3ec0715c211682820354ebb0dfc3de2436) of the old library Manager system, confirming the only differences were: - The expected checksum changes. - The since added "Log" field.
cmaglie
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db.jsonprovides storage of the library index data in the Library Manager back end. Thelibrary_index.jsoncontent forpreviously indexed library releases is generated from this data with only the data for new releases being generated from
the library repository content. For this reason, it's very important for the
db.jsoncontent to be correct.Checking the db.json generated from a run of the system against a "golden master" provides improved confidence that the
content remains correct during development on the project.
The "golden master" db.json was checked against the one generated by the final "production" engine version
(60ebae3ec0715c211682820354ebb0dfc3de2436) of the old library Manager system, confirming the only changes were: