Skip to content

Use tag name in release asset filename #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Use tag name in release asset filename #45

merged 1 commit into from
Jun 1, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 1, 2021

Previously the release asset archive that contains the pre-built libraries-repository-engine binary was named like:

libraries-repository-engine_Linux_64bit.tar.gz

This was inconsistent with the standard established in other Arduino tooling projects, so it should be changed to follow the standard convention of having the tag name in the archive file name:

libraries-repository-engine_0.0.2_Linux_64bit.tar.gz

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jun 1, 2021
@per1234 per1234 requested review from umbynos and rsora June 1, 2021 10:22
Previously the release asset archive that contains the pre-built `libraries-repository-engine` binary was named like:

libraries-repository-engine_Linux_64bit.tar.gz

This was inconsistent with the standard established in other Arduino tooling projects, so it should be changed to follow the standard convention of having the tag name in the archive file name:

libraries-repository-engine_0.0.2_Linux_64bit.tar.gz
@per1234 per1234 merged commit 5068e17 into arduino:main Jun 1, 2021
@per1234 per1234 deleted the version-asset branch June 1, 2021 10:28
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants