Skip to content

Disable CGO in builds to avoid linking newest GLIBC #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Disable CGO in builds to avoid linking newest GLIBC #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
# This is an "umbrella" task used to call any documentation generation processes the project has.
# It can be left empty if there are none.

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-general-formatting-task/Taskfile.yml

Check warning on line 53 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

53:121 [line-length] line too long (140 > 120 characters)

Check warning on line 53 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

53:121 [line-length] line too long (140 > 120 characters)
general:check-formatting:
desc: Check basic formatting style of all files
cmds:
Expand All @@ -67,9 +67,9 @@
desc: Build the Go code
dir: "{{.DEFAULT_GO_MODULE_PATH}}"
cmds:
- go build -v -o libraries-repository-engine{{exeExt}} {{.LDFLAGS}}
- CGO_ENABLED=0 go build -v -o libraries-repository-engine{{exeExt}} {{.LDFLAGS}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/test-go-task/Taskfile.yml

Check warning on line 72 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

72:121 [line-length] line too long (123 > 120 characters)

Check warning on line 72 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

72:121 [line-length] line too long (123 > 120 characters)
go:test:
desc: Run unit tests
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
Expand All @@ -84,7 +84,7 @@
{{.TEST_LDFLAGS}} \
{{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/test-go-integration-task/Taskfile.yml

Check warning on line 87 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

87:121 [line-length] line too long (135 > 120 characters)

Check warning on line 87 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

87:121 [line-length] line too long (135 > 120 characters)
go:test-integration:
desc: Run integration tests
deps:
Expand All @@ -107,21 +107,21 @@
- task: go:vet
- task: go:lint

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 110 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

110:121 [line-length] line too long (124 > 120 characters)

Check warning on line 110 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

110:121 [line-length] line too long (124 > 120 characters)
go:vet:
desc: Check for errors in Go code
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
cmds:
- go vet {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 117 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

117:121 [line-length] line too long (124 > 120 characters)

Check warning on line 117 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

117:121 [line-length] line too long (124 > 120 characters)
go:fix:
desc: Modernize usages of outdated APIs
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
cmds:
- go fix {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 124 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

124:121 [line-length] line too long (124 > 120 characters)

Check warning on line 124 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

124:121 [line-length] line too long (124 > 120 characters)
go:lint:
desc: Lint Go code
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
Expand All @@ -136,14 +136,14 @@
{{default "-min_confidence 0.8 -set_exit_status" .GO_LINT_FLAGS}} \
{{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 139 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

139:121 [line-length] line too long (124 > 120 characters)

Check warning on line 139 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

139:121 [line-length] line too long (124 > 120 characters)
go:format:
desc: Format Go code
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
cmds:
- go fmt {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-markdown-task/Taskfile.yml

Check warning on line 146 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

146:121 [line-length] line too long (130 > 120 characters)

Check warning on line 146 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

146:121 [line-length] line too long (130 > 120 characters)
markdown:check-links:
desc: Check for broken links
deps:
Expand Down Expand Up @@ -202,7 +202,7 @@
'
fi

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-markdown-task/Taskfile.yml

Check warning on line 205 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

205:121 [line-length] line too long (130 > 120 characters)

Check warning on line 205 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

205:121 [line-length] line too long (130 > 120 characters)
markdown:fix:
desc: Automatically correct linting violations in Markdown files where possible
deps:
Expand All @@ -210,7 +210,7 @@
cmds:
- npx markdownlint-cli --fix "**/*.md"

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-markdown-task/Taskfile.yml

Check warning on line 213 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

213:121 [line-length] line too long (130 > 120 characters)

Check warning on line 213 in Taskfile.yml

View workflow job for this annotation

GitHub Actions / Generate problem matcher output 

213:121 [line-length] line too long (130 > 120 characters)
markdown:lint:
desc: Check for problems in Markdown files
deps:
Expand Down
Loading