Adjust release workflow for new "v"-prefixed tag format #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go modules system requires the release Git tags to start with a "v" prefix. Historically, this project has used the otherwise more sensible approach of using the exact version number as a tag name. This meant that the module could only be used as a dependency via "pseudo-versions". For example, `go get github.com/arduino/libraries-repository-engine@latest` currently adds this travesty to your `go.mod` file: ```text require github.com/arduino/libraries-repository-engine v0.0.0-20220321045648-4999750bf965 ``` This causes several problems: - Unstable non-release versions of the module are more likely to be used by dependent projects - Automated release update services (i.e., Dependabot) are not available, resulting in dependent projects using outdated versions of the module The release workflow was configured for the previous non-prefixed tag format, so it must be adjusted for the new "v" prefixed tag format.
umbynos
approved these changes
Mar 21, 2022
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go modules system requires the release Git tags to start with a "v" prefix. Historically, this project has used the otherwise more sensible approach of using the exact version number as a tag name.
This meant that the module could only be used as a dependency via "pseudo-versions".
For example,
go get github.com/arduino/libraries-repository-engine@latestcurrently adds this travesty to yourgo.modfile:This causes several problems:
The release workflow was configured for the previous non-prefixed tag format, so it must be adjusted for the new "v" prefixed tag format.