Skip to content

Use force checkout #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

Use force checkout #11

merged 1 commit into from
May 10, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 9, 2021

Even though I don't know of a situation where this would be needed, it is how it was done before the switch to using
github.com/go-git/go-git:

https://github.com/bcmi-labs/arduino-modules/blob/v1.1.12/git/git_helper.go#L93

Since the previous system was working well, it seems best to emulate its behavior as closely as possible.

Reference:
https://pkg.go.dev/github.com/go-git/go-git/v5#CheckoutOptions

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 9, 2021
@per1234 per1234 requested review from silvanocerza, umbynos and rsora May 9, 2021 21:35
Even though I don't know of a situation where this would be needed, it is how it was done before the switch to using
`github.com/go-git/go-git`:

https://github.com/bcmi-labs/arduino-modules/blob/v1.1.12/git/git_helper.go#L93

Since the previous system was working well, it seems best to emulate its behavior as closely as possible.
@per1234 per1234 merged commit 111802d into arduino:master May 10, 2021
@per1234 per1234 deleted the force-checkout branch May 10, 2021 09:27
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants