Skip to content

Add CI workflow to lint and check formatting of Go code #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

MatteoPologruto
Copy link
Contributor

On every push and pull request that affects relevant files, check the repository's Go module for:

  • Common detectable errors in the code.
  • Use of outdated APIs
  • Code style violations
  • Code formatting inconsistency
  • Misconfiguration

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Mar 13, 2023
@MatteoPologruto MatteoPologruto self-assigned this Mar 13, 2023
@MatteoPologruto MatteoPologruto requested a review from cmaglie March 13, 2023 15:24
@umbynos
Copy link

umbynos commented Mar 15, 2023

@cmaglie could you please fix go:linterrors?

Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:237:6: exported type WndClass should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:250:6: exported type Point should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:255:6: exported type TagMSG should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:265:7: exported const WMQuit should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:267:7: exported const WsExDlgModalFrame should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:268:7: exported const WsExTopmost should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:269:7: exported const WsExTransparent should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:270:7: exported const WsExMDIChild should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:271:7: exported const WsExToolWindow should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:272:7: exported const WsExAppWindow should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:273:7: exported const WsExLayered should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:275:6: exported type GUID should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:282:6: exported type DevBroadcastDeviceInterface should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:298:7: exported const DeviceNotifyWindowHandle should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:299:7: exported const DeviceNotifySserviceHandle should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:300:7: exported const DeviceNotifyAllInterfaceClasses should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:302:7: exported const DbtDevtypeDeviceInterface should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:304:7: exported const PMNoRemove should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:305:7: exported const PMRemove should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:306:7: exported const PMNoYield should have comment or be unexported
Error: D:\a\go-win32-utils\go-win32-utils\syscall_windows.go:308:6: exported type WindowProcCallback should have comment or be unexported

@cmaglie
Copy link
Member

cmaglie commented Mar 27, 2023

Done, it must be rebased though.

MatteoPologruto and others added 4 commits March 27, 2023 14:19
On every push and pull request that affects relevant files, check the Go module for:

- Common detectable errors in the code.
- Use of outdated APIs
- Code style violations
- Code formatting inconsistency
- Misconfiguration
@MatteoPologruto MatteoPologruto merged commit 477982a into arduino:master Mar 27, 2023
@MatteoPologruto MatteoPologruto deleted the add-check-go branch March 27, 2023 15:39
@MatteoPologruto MatteoPologruto mentioned this pull request Jun 19, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants