Detection of recursion loops in ReadDirRecursive* methods #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares for the next change that requires to keep a shared state in the recursive calls. This change also avoids the need to pass `recursionFilter` and `filters` back into the recursive call.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 68.56% 68.00% -0.57%
==========================================
Files 7 7
Lines 404 400 -4
==========================================
- Hits 277 272 -5
Misses 93 93
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Jan 12, 2024
6 tasks
per1234
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the ReadDirRecursive* can detect symlink loops as they emerge during the search.
Previously the ReadDirRecursive* methods would fail later in the search with a "path too long" error or, in the worst case, they may lead to an exponentially long loop if the "too-long" symlinks were filtered out with a custom filter.