Skip to content

Add quick fix for italic styling #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 17, 2022
Merged

Conversation

sebromero
Copy link
Contributor

@sebromero sebromero commented Mar 2, 2022

Arduino's design system doesn't provide italic styling to emphasise text. As a result we should use bold emphasis only.

What Needs To Be Reviewed

  • Check if the "Fix linter issues" correctly replaces occurrences of italic styling.

How To Give Feedback

Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏

@sebromero sebromero requested a review from jhansson-ard March 2, 2022 14:19
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 2, 2022

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

@jhansson-ard
Copy link
Contributor

jhansson-ard commented Mar 2, 2022

@sebromero It seems like it missed one here, what do you think is the issue?
image

Here was also another weird example, where it seems something has gone wrong:
image

@sebromero
Copy link
Contributor Author

@jhansson-ard Good catch! I'll have a look

@sebromero
Copy link
Contributor Author

@jhansson-ard should be fixed now

@sebromero
Copy link
Contributor Author

@jhansson-ard actually no, it introduced a new problem 😓

@sebromero
Copy link
Contributor Author

@jhansson-ard Okay, now I'm more confident. Should work :-D

@jhansson-ard
Copy link
Contributor

jhansson-ard commented Mar 3, 2022

Now it seems as it takes even the image links 😬
image

And updates formulas...
image

@sebromero
Copy link
Contributor Author

@jhansson-ard Please try again 🙏

@jhansson-ard
Copy link
Contributor

@sebromero there were some minor disagreements between me and the linter, however this was because of human error - not the linter's fault. Meaning, people forgot to add the \ before any asterisks or underscores that they didn't want to be translated to formatting but actually just show the * or _ (for example in names of files or such)

@sebromero sebromero merged commit 9794b0a into main Mar 17, 2022
@sebromero sebromero deleted the sebromero/linter-fix-italic branch March 17, 2022 17:18
Serjlee pushed a commit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants