Skip to content

fix: updating central device code #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

Esquirio
Copy link
Contributor

What Needs To Be Reviewed

  • In Tutorial Toolbox, removed the Arduino LSM6DS3 library, but it is not necessary.
  • Fixing the installation guide link, because it is broken.
  • The two Arduinos didn’t connect, the problem is in the central device code. It is necessary to change the name of the peripheral device:
    Instead:
if (peripheral.localName().indexOf("LED") < 0) {
      Serial.println("No 'LED' in name");
      return;  // If the name doeshn't have "LED" in it then ignore it
 }

It should be:

if (peripheral.localName().indexOf("Button Device") < 0) {
      Serial.println("No 'Button Device' in name");
      return;  // If the name doeshn't have "Button Device" in it then ignore it
}
  • Changed the LEDB to LED_BUILTIN
    The LEDB requires the WiFiNINA library, but even when I included it the LEDB, LEDR, and LEDG didn’t turn on.

According to the Arduino Nano RP2040 datasheet, the common anode RGB LED is controlled by the Nina W-102 module, which is the same Bluetooth module. I am not sure, but I’m guessing that when we use Bluetooth, we cannot use the RGB LED.

  • Finally, You could change the comment in line 10
    Instead
    // start scanning for LED BLE peripherals
    It should be used
    // start scanning for Button Device BLE peripherals
    Thank guy, have a nice week.

How To Give Feedback

Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏

@Esquirio Esquirio requested a review from karlsoderby February 21, 2022 19:11
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 21, 2022

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022

CLA assistant check
All committers have signed the CLA.

…rp2040-ble-device-to-device/rp2040-ble-device-to-device.md

Co-authored-by: Sebastian Romero <[email protected]>
@Esquirio Esquirio merged commit 79afd8a into main Feb 24, 2022
@Esquirio Esquirio deleted the Esquirio/fixing_BLE_Device_to_Device_tutorial branch February 24, 2022 13:26
Serjlee pushed a commit that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants