Skip to content

Add IoT-Quartet tutorial for X8 [PC-806] #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 17, 2022
Merged

Add IoT-Quartet tutorial for X8 [PC-806] #457

merged 27 commits into from
Aug 17, 2022

Conversation

ArduinoBot
Copy link
Collaborator

What This PR Changes

  • Create tutorial draft

Contribution Guidelines

@sebromero sebromero changed the title IoT-Quartet [PC-806] Add IoT-Quartet tutorial for X8 [PC-806] Aug 12, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 12, 2022 •
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

@marqdevx marqdevx self-requested a review August 12, 2022 10:16
@marqdevx
Copy link
Member

What is the difference for commands:
/ #<command> and #<command>

marqdevx
marqdevx requested changes Aug 12, 2022
View reviewed changes
Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review the screenshots, try to zoom in, or make the stuff bigger if possible 😄
The content itself LGTM 👍

@per1234 per1234 added enhancement New feature or request arduino Bugs and fixes added by the Arduino Team labels Aug 13, 2022
@canchebagur
Copy link
Contributor

Could you review the screenshots, try to zoom in, or make the stuff bigger if possible 😄 The content itself LGTM 👍

I can make the screenshots bigger, but I am unsure if that will help 😕 Do you think it is necessary to retake the screenshots?

@marqdevx
Copy link
Member

Could you review the screenshots, try to zoom in, or make the stuff bigger if possible 😄 The content itself LGTM 👍

I can make the screenshots bigger, but I am unsure if that will help 😕 Do you think it is necessary to retake the screenshots?

I would say at least remake the terminal one zooming in somehow, or remove it and have the output as a code block

The one with the dashboard i think it is fine as you see the overall and the area of focus 😄

@canchebagur
Copy link
Contributor

Could you review the screenshots, try to zoom in, or make the stuff bigger if possible 😄 The content itself LGTM 👍

I made the change with the terminal screenshot. Let me know your thoughts about the result

canchebagur
canchebagur reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@canchebagur canchebagur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminal screenshot updated.

@canchebagur
Copy link
Contributor

canchebagur commented Aug 17, 2022 •
edited
Loading

@marqdevx I changed the terminal screenshot, but in the Gatsby preview is shown the old one, I already checked the file, and it is updated :/

marqdevx
marqdevx approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx
Copy link
Member

The preview not always updates the content on new commits :(
I built it locally and it's good

I will note to check the terminal code blocks in the future :D

@canchebagur canchebagur merged commit e7b1085 into main Aug 17, 2022
@canchebagur canchebagur deleted the sync/canchebagur/datalogging-x8 branch August 17, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@canchebagur canchebagur canchebagur left review comments

@marqdevx marqdevx marqdevx approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArduinoBot @marqdevx @canchebagur @per1234 @TaddyHC