Skip to content

Portenta X8: Video Output [PC-891] #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2022
Merged

Conversation

marqdevx
Copy link
Member

What This PR Changes

  • Add Portenta X8 video output tutorial

@marqdevx marqdevx added new Tutorial arduino Bugs and fixes added by the Arduino Team pro labels May 19, 2022
@marqdevx marqdevx self-assigned this May 19, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 19, 2022

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

@marqdevx marqdevx force-pushed the marqdevx/portenta-X8/video-output branch from 05d5dfa to 38fadf6 Compare May 23, 2022 09:46
@marqdevx marqdevx marked this pull request as ready for review May 23, 2022 12:53
@marqdevx
Copy link
Member Author

Linter has a weird issue
image
With my offline built it was showing every picture fine.

@per1234
Copy link
Contributor

per1234 commented May 27, 2022

Hi @marqdevx. I believe this remaining one:

❌ ERROR: Asset 'portentaX8-home-screen.PNG' is not used. Location: ../../content/hardware/04.pro/boards/portenta-x8/tutorials/display-output-webgl/content.md:1:1
❌ ERROR: Image doesn't exist: assets/portentaX8-home-screen.png Location: ../../content/hardware/04.pro/boards/portenta-x8/tutorials/display-output-webgl/content.md:137:19

Is caused by the file extension .PNG. On a case insensitive file system such as Windows, the path in the link:

![X8 home-screen](assets/portentaX8-home-screen.png)

and the actual path of the file (assets/portentaX8-home-screen.PNG) are equivalent. But the linter runs on the case sensitive file system of Linux, where these are not the same.

My recommendation is to rename the image file to use the more standard .png extension.

Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx
Copy link
Member Author

Hi @marqdevx. I believe this remaining one:

❌ ERROR: Asset 'portentaX8-home-screen.PNG' is not used. Location: ../../content/hardware/04.pro/boards/portenta-x8/tutorials/display-output-webgl/content.md:1:1
❌ ERROR: Image doesn't exist: assets/portentaX8-home-screen.png Location: ../../content/hardware/04.pro/boards/portenta-x8/tutorials/display-output-webgl/content.md:137:19

Is caused by the file extension .PNG. On a case insensitive file system such as Windows, the path in the link:

![X8 home-screen](assets/portentaX8-home-screen.png)

and the actual path of the file (assets/portentaX8-home-screen.PNG) are equivalent. But the linter runs on the case sensitive file system of Linux, where these are not the same.

My recommendation is to rename the image file to use the more standard .png extension.

I did that but git didnt recognize the change (Should have used git mv) but yes Benjamin spotted and fixed by deleting and adding it again with the lower caps variant.

Thanks 😄

@marqdevx marqdevx merged commit 8798aa5 into main May 27, 2022
@marqdevx marqdevx deleted the marqdevx/portenta-X8/video-output branch May 27, 2022 09:28
Serjlee pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team new pro Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants