Skip to content

[PXCT-17] add RTC RPC example #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2024
Merged

[PXCT-17] add RTC RPC example #2298

merged 3 commits into from
Dec 5, 2024

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR adds an example on how to access the RTC from the M4 core on the Arduino GIGA R1 WiFi.

Contribution Guidelines

@Hannes7eicher Hannes7eicher added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team maker preview labels Nov 25, 2024
@Hannes7eicher Hannes7eicher changed the title add RTC RPC example [PXCT-17] add RTC RPC example Nov 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Preview Deployment

🚀 Preview this PR: https://675027572ce8ec384341741c--docs-content.netlify.app
📍 Commit SHA: c8eed9b

karlsoderby
karlsoderby requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hannes7eicher , appears to be working. However we are using the single sketch approach (uploading the same sketch to the different cores).

I think it might be best to look at creating a specific M4 sketch, and a specific M7 sketch.

@Hannes7eicher
Copy link
Contributor Author

@karlsoderby I think that's a good idea! I split apart the sketch. Take a look and let me know what you think.

karlsoderby
karlsoderby requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestion @Hannes7eicher . I think it's best to leave RTC.set() uncommented but let me know if there was a reason to leave like it that and we can adjust.

Otherwise everything looks great.

@Hannes7eicher
Copy link
Contributor Author

All suggestions applied 😁

@Hannes7eicher Hannes7eicher merged commit c23e95e into main Dec 5, 2024
4 checks passed
@Hannes7eicher Hannes7eicher deleted the hannes7eicher/GIGA-RTC-M4 branch December 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation maker preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hannes7eicher @karlsoderby