-
-
Notifications
You must be signed in to change notification settings - Fork 438
[PXCT-160] Appwizard tutorial #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview Deployment🚀 Preview this PR: https://67e2d83a3336b46f5d96bb47--docs-content.netlify.app |
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
...hields/giga-display-shield/tutorials/13.appwizard-guide/assets/appwizard-demo-folder-src.png
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
…/13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BenjaminDannegard I reviewed the tutorial and left some minor comments.
I would recommend for future tutorials to set your computer background to a solid color, (hex: D6EEF0) and to take screenshots directly on it so to avoid cropping images and giving consistency to the style.
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
…/13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <[email protected]>
…/13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Now
Changes and feedback were applied, dismissing review just to unblick the merge without bothering people
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the latest changes
What This PR Changes
Contribution Guidelines