Skip to content

[TC-292] Update X8 Datasheet #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2022
Merged

[TC-292] Update X8 Datasheet #212

merged 5 commits into from
May 10, 2022

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented May 10, 2022 •
edited
Loading

What This PR Changes

  • Clearly state that accessories are not included
  • Removed unused components in current release
  • State requirement of carrier board for the bootloader functionality

Contribution Guidelines

@aliphys aliphys requested a review from sebromero May 10, 2022 08:44
@aliphys aliphys marked this pull request as ready for review May 10, 2022 08:44
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 10, 2022 •
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

sebromero
sebromero requested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small details, see suggestions. Otherwise looks good.

sebromero
sebromero approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero
Copy link
Contributor

@aliphys Check the linter complaints before merging

@aliphys aliphys merged commit 6fa6538 into main May 10, 2022
@aliphys aliphys deleted the aliphys/X8Updates branch May 10, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliphys @sebromero