Skip to content

[MKC-1607] Updated cloud editor mentions #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

BenjaminDannegard
Copy link
Contributor

@BenjaminDannegard BenjaminDannegard commented Jul 17, 2024

What This PR Changes

  • Replaced web editor with cloud editor

Contribution Guidelines

@g-castronovo g-castronovo added arduino Bugs and fixes added by the Arduino Team cloud fixes relating to Cloud updates labels Jul 18, 2024
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done from maker side.
@jcarolinares your turn :D

@jcarolinares jcarolinares self-requested a review July 31, 2024 08:41
Copy link

github-actions bot commented Jul 31, 2024

Preview Deployment

🚀 Preview this PR: https://66e076316cc98d6329ca7cce--docs-content.netlify.app
📍 Commit SHA: 8753aba

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobhylen done, as we said next time let's do it smaller, I think it will be great to all of us :)

@BenjaminDannegard and @jacobhylen I think we should add the entry logs to those datasheets @TaddyHC can help with the pro ones so the overall additional work is more balanced, tell me what you think please

@jacobhylen jacobhylen mentioned this pull request Jul 31, 2024
1 task
@BenjaminDannegard
Copy link
Contributor Author

@jcarolinares if @TaddyHC can help with the PRO datasheets I can handle the MKR datasheets, then we can merge this massive PR :)

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@BenjaminDannegard BenjaminDannegard merged commit 3b1a83b into main Sep 11, 2024
4 of 5 checks passed
@BenjaminDannegard BenjaminDannegard deleted the benjamindannegard/cloud-editor-naming-fix branch September 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team cloud fixes relating to Cloud updates preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants