Skip to content

Update simple-audio-player.md #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

giuggiodk
Copy link

@giuggiodk giuggiodk commented May 31, 2024

Changed constant 4 with static SDCARD_SS_PIN

What This PR Changes

  • As SD.begin(4) fails using the constant, the solution is letting the library to decide itself the correct port number

Contribution Guidelines

Changed constant 4 with static SDCARD_SS_PIN
@CLAassistant
Copy link

CLAassistant commented May 31, 2024

CLA assistant check
All committers have signed the CLA.

@jhansson-ard
Copy link
Contributor

Hello @giuggiodk!

Please sign the CLA and we will take a look at your proposal. Thank you ⭐
cc @jacobhylen

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community labels May 31, 2024
@jacobhylen
Copy link
Contributor

Hello @giuggiodk 👋
The constant SDCARD_SS_PIN is not defined in the library, but is only in the samd core for the MKRZero variant.
As such, your proposal will unfortunately only compile for that specific board.

I still want to say thank you for taking the time to contribute.

@jacobhylen jacobhylen closed this Jul 31, 2024
@giuggiodk
Copy link
Author

giuggiodk commented Jul 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants