Skip to content

Update web-editor with new key cloud-editor #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update web-editor with new key cloud-editor #1980

merged 2 commits into from
Jun 7, 2024

Conversation

Matteo-it
Copy link
Contributor

@Matteo-it Matteo-it changed the title Update web-editor with new key cloud-editor [Waiting 2.0.9] Update web-editor with new key cloud-editor May 24, 2024
@Matteo-it Matteo-it requested a review from jhansson-ard May 24, 2024 13:26
@jhansson-ard jhansson-ard added arduino Bugs and fixes added by the Arduino Team infrastructure Fixes and updates to the infrastructure of the repo preview labels May 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Preview Deployment

🚀 Preview this PR: https://6662e379b9ecdbf85df158cd--docs-content.netlify.app
📍 Commit SHA: f5a8bc6

@jhansson-ard
Copy link
Contributor

@Matteo-it make sure to update this to the main branch when you are ready, that way the spell check will go through 🙏🏼

@jhansson-ard jhansson-ard requested a review from jacobhylen May 31, 2024 08:42
@Matteo-it Matteo-it force-pushed the Matteo-it/update-web-editor-key branch from 95c3c31 to 4c0ee8d Compare June 6, 2024 07:55
@Matteo-it Matteo-it marked this pull request as ready for review June 6, 2024 07:57
@Matteo-it Matteo-it changed the title [Waiting 2.0.9] Update web-editor with new key cloud-editor Update web-editor with new key cloud-editor Jun 6, 2024
@Matteo-it Matteo-it requested a review from jcarolinares June 6, 2024 08:00
jacobhylen
jacobhylen approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Maker side :)

@Matteo-it Matteo-it force-pushed the Matteo-it/update-web-editor-key branch from b364891 to 91d3624 Compare June 7, 2024 10:19
@Matteo-it Matteo-it merged commit 3c35df7 into main Jun 7, 2024
4 checks passed
@Matteo-it Matteo-it deleted the Matteo-it/update-web-editor-key branch June 7, 2024 11:05
@jcarolinares
Copy link
Contributor

jcarolinares commented Jun 10, 2024 •
edited
Loading

Hello

@Matteo-it you have to wait for pro approval, @jacobhylen keep in mind @Matteo-it just saw the approval and didn't understand he has to wait, next time do a comment approval and wait for mine that was the one left

I've just realise randomly these changes, this is not acceptable

@Matteo-it and @jacobhylen please report me properly when something affects Pro Content, thanks

@Matteo-it
Copy link
Contributor Author

Matteo-it commented Jun 10, 2024 •
edited
Loading

Hello @jcarolinares,

I'm sorry, I was not clear that I had to wait for more than one approval, thank you for clarifying! 🙏🏻
If changes to this PR are a problem I can make a revert 👍🏻

cc. @jacobhylen

@jcarolinares
Copy link
Contributor

Changes are great, no need to revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobhylen jacobhylen jacobhylen approved these changes

@jhansson-ard jhansson-ard Awaiting requested review from jhansson-ard

@jcarolinares jcarolinares Awaiting requested review from jcarolinares

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team infrastructure Fixes and updates to the infrastructure of the repo preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matteo-it @jhansson-ard @jcarolinares @jacobhylen