Skip to content

[PC-1688] Nano Matter: Technical Information Revamp #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 8, 2024

Conversation

ArduinoBot
Copy link
Collaborator

@ArduinoBot ArduinoBot commented May 7, 2024

What This PR Changes

Nano Matter technical information revamp

  • Schematics
  • Pinout resources
  • Tech specs
  • Datasheet

Contribution Guidelines

@ArduinoBot ArduinoBot added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team labels May 7, 2024
@ArduinoBot ArduinoBot requested a review from martab1994 May 7, 2024 15:16
@jcarolinares jcarolinares requested a review from mcmchris May 7, 2024 15:28
Copy link
Collaborator

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcarolinares
Copy link
Contributor

Hello @jhansson-ard and @lukdog I'm afraid we need you help guys regarding this special case

Validate Content Error is related with a not recommended underscore, maybe that should be a warning but in any of the cases due to the lack of admin permissions we need your help to merge this pull request

Launch was today so this is a priority for us, thank you

@jhansson-ard
Copy link
Contributor

Hello! You need to move the datasheet folder to the "normal" folder tree, so here in this folder. This will not make any difference to the behavior we see now, but we should test it on oniudra just to be safe before we merge ⭐

Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much

@jcarolinares jcarolinares merged commit 725b29c into main May 8, 2024
5 checks passed
@jcarolinares jcarolinares deleted the sync/taddy/nano-matter-technical-info-revamp branch May 8, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants