Skip to content

Document action's fetch depth requirement #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Document action's fetch depth requirement #11

merged 1 commit into from
Jun 7, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 30, 2021

The changelog is generated from the commit history. But the ubiquitous actions/checkout action does a shallow fetch by default. This works perfectly well for almost every usage, so many users may not even be aware of the shallowness of the resulting repository or the ability to control the behavior via that action's fetch-depth input.

If you use the default actions/checkout configuration in your workflow, the resulting will contain, at most, a single entry. This can be extremely confusing. So the users will likely find some guidance in the required checkout configuration to be valuable.


The existing documentation structure didn't accommodate the addition of this information without significantly harming its readability. For this reason, I took the liberty of adding some headings to establish the necessary structure to contain the added content.

The changelog is generated from the commit history. But the ubiquitous `actions/checkout` action does a shallow fetch by default. This works perfectly well for almost every usage, so many users may not even be aware of the shallowness of the resulting repository or the ability to control the behavior via that action's `fetch-depth` input.

If you use the default `actions/checkout` configuration in your workflow, the resulting will contain, at most, a single entry. This can be extremely confusing. So the users will likely find some guidance in the required checkout configuration to be valuable.
@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels May 30, 2021
@per1234 per1234 requested a review from silvanocerza May 30, 2021 05:58
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Per, completely forgot to document this important bit.

@per1234 per1234 merged commit 2cb7992 into arduino:main Jun 7, 2021
@per1234 per1234 deleted the document-fetch-depth branch June 7, 2021 06:51
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants