check if changelogDir is not null #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
force-pushed
the
umbynos/check_changelog_dir
branch
from
d66929a to
7266b3d
Compare
umbynos
force-pushed
the
umbynos/check_changelog_dir
branch
from
7266b3d to
ebc9f86
Compare
silvanocerza
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, there was a check missing:
If the
changelogDiris not defined, the code tries in any case to create a directory. That behavior is wrong.Maybe it would be even better to add a test for it.
I discovered this bug by using the action with
changelog-file-path: "CHANGELOG.md"(which BTW should be the default setting)