Assets folder recognition fix #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebromero
reviewed
Aug 26, 2022
validations/assets.js
Outdated
| @@ -89,7 +89,8 @@ function validateSVGFiles(article){ | |||
| * @returns an array of ValidationIssue objects for the found issues. | |||
| */ | |||
| function validateAssetsFolderName(article){ | |||
| if(article.assets.length > 0 && article.assetsFolder === null){ | |||
|
|
|||
| if(article.assets.length > 0 && article.assetsFolder != "assets"){ | |||
There was a problem hiding this comment.
This changes the behavior. "images" should also be allowed. Those cases should be handled by the assetsFolder property. If it doesn't return null, the problem is elsewhere.
There was a problem hiding this comment.
Then on the assetsFolder function
// Try to figure out assets path from the referenced images
const usedAssetPaths = this.referencedImages.map((assetPath) => {
const directory = path.dirname(assetPath)
if(!directory) return null;
return directory.split("/")[0]; // <-- This returns the "wrong" assets folder name
}) There was a problem hiding this comment.
assetsFolder just returns the folder, it doesnt matter the name, in the assets.js should be the logic which determines if it is correct or not, isnt it?
There was a problem hiding this comment.
@marqdevx You're right. Let me push a commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateAssetsFolderNamefixed scenario: when it is null it does not mean the name is correct