Skip to content

Correctly detect and handle installation path collisions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Correctly detect and handle installation path collisions #28

merged 1 commit into from
Jul 31, 2021

Conversation

per1234
Copy link
Collaborator

@per1234 per1234 commented Jul 31, 2021

compilesketches.CompileSketches.install_from_path() has code for detecting a pre-existing file/folder at the installation destination path and either removing it or else failing with a helpful error message depending on the setting of the force parameter.

The previous detection code did not work correctly in the event the pre-existing item was a broken symlink.

The previous removal code did not work correctly in the event the pre-existing item was a symlink or file.

`compilesketches.CompileSketches.install_from_path()` has code for detecting a pre-existing file/folder at the
installation destination path and either removing it or else failing with a helpful error message depending on the
setting of the `force` parameter.

The previous detection code did not work correctly in the event the pre-existing item was a broken symlink.

The previous removal code did not work correctly in the event the pre-existing item was a symlink or file.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jul 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #28 (7f3a99e) into main (3deecbf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines         1584      1596   +12     
=========================================
+ Hits          1584      1596   +12     
Impacted Files Coverage Δ
compilesketches/compilesketches.py 100.00% <100.00%> (ø)
compilesketches/tests/test_compilesketches.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3deecbf...7f3a99e. Read the comment docs.

@per1234 per1234 merged commit c6c5547 into arduino:main Jul 31, 2021
@per1234 per1234 deleted the fix-exist-handling branch July 31, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants