Correctly detect and handle installation path collisions #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compilesketches.CompileSketches.install_from_path()` has code for detecting a pre-existing file/folder at the installation destination path and either removing it or else failing with a helpful error message depending on the setting of the `force` parameter. The previous detection code did not work correctly in the event the pre-existing item was a broken symlink. The previous removal code did not work correctly in the event the pre-existing item was a symlink or file.
per1234
added
type: imperfection
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 1584 1596 +12
=========================================
+ Hits 1584 1596 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilesketches.CompileSketches.install_from_path()has code for detecting a pre-existing file/folder at the installation destination path and either removing it or else failing with a helpful error message depending on the setting of theforceparameter.The previous detection code did not work correctly in the event the pre-existing item was a broken symlink.
The previous removal code did not work correctly in the event the pre-existing item was a symlink or file.