Skip to content

Add infrastructure to lint YAML files #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions .github/workflows/check-yaml-task.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/check-yaml-task.md
name: Check YAML

# See: https://docs.github.com/actions/using-workflows/events-that-trigger-workflows
on:
create:
push:
paths:
- ".python-version"
- ".yamllint*"
- "poetry.lock"
- "pyproject.toml"
# Source: https://github.com/ikatyang/linguist-languages/blob/master/data/YAML.json (used by Prettier)
- "**/.clang-format"
- "**/.clang-tidy"
- "**/.gemrc"
- "**/glide.lock"
- "**.ya?ml*"
- "**.mir"
- "**.reek"
- "**.rviz"
- "**.sublime-syntax"
- "**.syntax"
pull_request:
paths:
- ".python-version"
- ".yamllint*"
- "poetry.lock"
- "pyproject.toml"
# Source: https://github.com/ikatyang/linguist-languages/blob/master/data/YAML.json (used by Prettier)
- "**/.clang-format"
- "**/.clang-tidy"
- "**/.gemrc"
- "**/glide.lock"
- "**.ya?ml*"
- "**.mir"
- "**.reek"
- "**.rviz"
- "**.sublime-syntax"
- "**.syntax"
schedule:
# Run periodically to catch breakage caused by external changes.
- cron: "0 9 * * WED"
workflow_dispatch:
repository_dispatch:

jobs:
run-determination:
runs-on: ubuntu-latest
outputs:
result: ${{ steps.determination.outputs.result }}
steps:
- name: Determine if the rest of the workflow should run
id: determination
run: |
RELEASE_BRANCH_REGEX="refs/heads/[0-9]+.[0-9]+.x"
# The `create` event trigger doesn't support `branches` filters, so it's necessary to use Bash instead.
if [[
"${{ github.event_name }}" != "create" ||
"${{ github.ref }}" =~ $RELEASE_BRANCH_REGEX
]]; then
# Run the other jobs.
RESULT="true"
else
# There is no need to run the other jobs.
RESULT="false"
fi

echo "result=$RESULT" >> $GITHUB_OUTPUT

check:
name: ${{ matrix.configuration.name }}
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-latest

strategy:
fail-fast: false

matrix:
configuration:
- name: Generate problem matcher output
# yamllint's "github" output type produces annotated diffs, but is not useful to humans reading the log.
format: github
# The other matrix job is used to set the result, so this job is configured to always pass.
continue-on-error: true
- name: Check formatting
# yamllint's "colored" output type is most suitable for humans reading the log.
format: colored
continue-on-error: false

steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Install Python
uses: actions/setup-python@v4
with:
python-version-file: .python-version

- name: Install Poetry
run: |
pipx install \
--python "$(which python)" \
poetry

- name: Install Task
uses: arduino/setup-task@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 3.x

- name: Check YAML
continue-on-error: ${{ matrix.configuration.continue-on-error }}
run: task yaml:lint YAMLLINT_FORMAT=${{ matrix.configuration.format }}
8 changes: 6 additions & 2 deletions .github/workflows/test-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,12 @@ jobs:
jq \
--null-input \
--exit-status \
--slurpfile generated "$reportPath" \
--slurpfile golden "${{ env.TESTDATA_REPORTS_PATH }}/${{ needs.all-inputs.outputs.report-artifact-name }}/$(basename "$reportPath")" \
--slurpfile \
generated \
"$reportPath" \
--slurpfile \
golden \
"${{ env.TESTDATA_REPORTS_PATH }}/${{ needs.all-inputs.outputs.report-artifact-name }}/$(basename "$reportPath")" \
'($generated|.[0].boards) == ($golden|.[0].boards)'
) && (
# Check the commit_hash value
Expand Down
76 changes: 76 additions & 0 deletions .yamllint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-yaml/.yamllint.yml
# See: https://yamllint.readthedocs.io/en/stable/configuration.html
# The code style defined in this file is the official standardized style to be used in all Arduino tooling projects and
# should not be modified.
# Note: Rules disabled solely because they are redundant to Prettier are marked with a "Prettier" comment.

rules:
braces:
level: error
forbid: non-empty
min-spaces-inside: -1 # Prettier
max-spaces-inside: -1 # Prettier
min-spaces-inside-empty: -1 # Prettier
max-spaces-inside-empty: -1 # Prettier
brackets:
level: error
forbid: non-empty
min-spaces-inside: -1 # Prettier
max-spaces-inside: -1 # Prettier
min-spaces-inside-empty: -1 # Prettier
max-spaces-inside-empty: -1 # Prettier
colons: disable # Prettier
commas: disable # Prettier
comments: disable # Prettier
comments-indentation: disable # Prettier
document-end: disable # Prettier
document-start: disable
empty-lines: disable # Prettier
empty-values: disable
hyphens: disable # Prettier
indentation: disable # Prettier
key-duplicates: disable # Prettier
key-ordering: disable
line-length:
level: warning
max: 120
allow-non-breakable-words: true
allow-non-breakable-inline-mappings: true
new-line-at-end-of-file: disable # Prettier
new-lines: disable # Prettier
octal-values:
level: warning
forbid-implicit-octal: true
forbid-explicit-octal: false
quoted-strings: disable
trailing-spaces: disable # Prettier
truthy:
level: error
allowed-values:
- "true"
- "false"
- "on" # Used by GitHub Actions as a workflow key.
check-keys: true

yaml-files:
# Source: https://github.com/ikatyang/linguist-languages/blob/master/data/YAML.json (used by Prettier)
- ".clang-format"
- ".clang-tidy"
- ".gemrc"
- ".yamllint"
- "glide.lock"
- "*.yml"
- "*.mir"
- "*.reek"
- "*.rviz"
- "*.sublime-syntax"
- "*.syntax"
- "*.yaml"
- "*.yaml-tmlanguage"
- "*.yaml.sed"
- "*.yml.mysql"

ignore: |
/.git/
__pycache__/
node_modules/
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
[![Check Taskfiles status](https://github.com/arduino/compile-sketches/actions/workflows/check-taskfiles.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/check-taskfiles.yml)
[![Check ToC status](https://github.com/arduino/compile-sketches/actions/workflows/check-toc-task.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/check-toc-task.yml)
[![Check Workflows status](https://github.com/arduino/compile-sketches/actions/workflows/check-workflows-task.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/check-workflows-task.yml)
[![Check YAML status](https://github.com/arduino/compile-sketches/actions/workflows/check-yaml-task.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/check-yaml-task.yml)
[![Spell Check status](https://github.com/arduino/compile-sketches/actions/workflows/spell-check-task.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/spell-check-task.yml)
[![Sync Labels status](https://github.com/arduino/compile-sketches/actions/workflows/sync-labels-npm.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/sync-labels-npm.yml)
[![Test Python status](https://github.com/arduino/compile-sketches/actions/workflows/test-python-poetry-task.yml/badge.svg)](https://github.com/arduino/compile-sketches/actions/workflows/test-python-poetry-task.yml)
Expand Down
11 changes: 11 additions & 0 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tasks:
- task: npm:validate
- task: python:lint
- task: python:test
- task: yaml:lint

fix:
desc: Make automated corrections to the project's files
Expand Down Expand Up @@ -474,3 +475,13 @@ tasks:
else
echo "{{.RAW_PATH}}"
fi

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-yaml-task/Taskfile.yml
yaml:lint:
desc: Check for problems with YAML files
deps:
- task: poetry:install-deps
vars:
POETRY_GROUPS: dev
cmds:
- poetry run yamllint --format {{default "colored" .YAMLLINT_FORMAT}} .
39 changes: 36 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ pytest = "7.2.2"
pytest-mock = "3.10.0"
flake8 = "6.0.0"
pep8-naming = "0.13.3"
yamllint = "1.30.0"

[tool.poetry.group.external]
# Provided only for use by boards platforms
Expand Down