Skip to content

Add CI workflow to validate action.yml against JSON schema #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Add CI workflow to validate action.yml against JSON schema #11

merged 2 commits into from
Oct 26, 2020

Conversation

per1234
Copy link
Collaborator

@per1234 per1234 commented Oct 25, 2020

This uses a community-generated schema (because there is no official one), but the schema is well done and actively maintained.

Demonstration of failed validation: https://github.com/arduino/compile-sketches/runs/1304026010

This uses a community-generated schema, but it's well done and actively maintained.
These changes seem a bit silly, but they are indeed required by the official specification (even though even GitHub
doesn't bother to specify the `inputs.<input_id>.required` value for inputs with an `inputs.<input_id>.default` key in
their official workflows).
@per1234 per1234 added the type: enhancement Proposed improvement label Oct 25, 2020
@per1234 per1234 requested a review from giulcioffi October 25, 2020 05:04
@per1234 per1234 changed the title @per1234 Add CI workflow to validate action.yml against JSON schema Add CI workflow to validate action.yml against JSON schema Oct 25, 2020
Copy link
Contributor

@giulcioffi giulcioffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@per1234 per1234 merged commit 5f0632e into arduino:main Oct 26, 2020
@per1234 per1234 deleted the validate-action_yml branch October 26, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants