Add support for dependencies preparation to general:cache-dep-licenses task
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` task The `general:cache-dep-licenses` task is used to generate metadata about the licenses of the project's dependencies. When using some dependency management systems, it is necessary to run an operation via the dependency management tool prior to generating the metadata. Since this task is a standardized "asset" which is intended to be usable with any project, a call to a `general:prepare-deps` task was added to the `general:cache-dep-licenses` task in order to allow it to be used with such project types. The operation required by the specific dependencies management system in use is performed in the `general:prepare-deps` task. It happens that such a preparatory operation is not necessary with the Go modules dependency management system, so an empty task is provided for use in Go module-based projects. Since this project is Go module-based, the change is not essential. However, it is best to keep the asset in sync with the upstream copy to facilitate maintenance of the project infrastructure.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
general:cache-dep-licensestask is used to generate metadata about the licenses of the project's dependencies.When using some dependency management systems, it is necessary to run an operation via the dependency management tool prior to generating the metadata. Since this task is a standardized "asset" which is intended to be usable with any project, a call to a
general:prepare-depstask was added to thegeneral:cache-dep-licensestask in order to allow it to be used with such project types.The operation required by the specific dependencies management system in use is performed in the
general:prepare-depstask. It happens that such a preparatory operation is not necessary with the Go modules dependency management system, so an empty task is provided for use in Go module-based projects.Since this project is Go module-based, the change is not essential. However, it is best to keep the asset in sync with the upstream copy to facilitate maintenance of the project infrastructure.