Skip to content

Linebreak set to LF as per SerialPlotterProtocol #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

Linebreak set to LF as per SerialPlotterProtocol #12

merged 1 commit into from
Sep 5, 2022

Conversation

nmzaheer
Copy link
Contributor

@nmzaheer nmzaheer commented Sep 4, 2022

This commit changes the default linebreak character from CRLF to LF as per SerialPlotterProtocol and resolves #8

The code for random value generator is also updated.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Sep 4, 2022
@per1234 per1234 self-assigned this Sep 4, 2022
per1234
per1234 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @nmzaheer!

@per1234 per1234 merged commit eac6d39 into arduino:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@per1234 per1234

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LF line breaks on records
3 participants
@nmzaheer @CLAassistant @per1234