Do not insert prototypes in the middle of a line. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The insertion point of prototypes may be detected to be in the middle
of a line for example in the following sketch:
int a; int b=forwardDeclared();
void setup() {}
void loop() {}
int forwardDeclared() { return 0; }
the insertion point is determined to be between `int a;` and `int b=..`
since the latter declaration use a forward-declared function to
initialize variable.
Before this patch this resulted in a stray `#line` directive inserted in
the middle of a line:
int a; #line 1 ...... <- added prototype line
int forwardDeclared(); <- added prototype
#line 2..... <- other prototypes....
......
This patch avoids the situation above by inserting a newline just before
the first `#line` directive if the insertion point happens to be in the
middle of a line.
Fix #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insertion point of prototypes may be detected to be in the middle of a line for example in the following sketch:
the insertion point is determined to be between
int a;andint b=..since the latter declaration use a forward-declared function to initialize variable.Before this patch this resulted in a stray
#linedirective inserted in the middle of a line:This patch avoids the situation above by inserting a newline just before the first
#linedirective if the insertion point happens to be in the middle of a line.Fix #7