Skip to content

Add example to update firmware on modulinos with MCU #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 20, 2025
Merged

Conversation

sebromero
Copy link
Contributor

This PR adds a script that allows to dynamically update the firmware on connected modulinos.

@sebromero sebromero requested a review from Copilot February 20, 2025 15:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

examples/firmware_update.py:35

  • [nitpick] The variable name 'bus' is too generic. Consider renaming it to something more descriptive like 'i2c_bus'.
bus = None # Change this to the I2C bus you are using on 3rd party host boards

examples/firmware_update.py:266

  • The 'run' function initializes the flashing process but there's no indication of explicit test coverage for this function.
def run(bus: I2C):

src/modulino/modulino.py:319

  • The docstring for 'available_devices' should be updated to include the new 'bus' parameter.
bus (I2C): The I2C bus to use. If not provided, the default I2C bus will be used.

@sebromero sebromero merged commit ef0301c into main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant